From 152db649a38d585253bcadd8983edc2639bf9ca3 Mon Sep 17 00:00:00 2001 From: avivkeller Date: Fri, 26 Jun 2026 13:46:58 -0400 Subject: [PATCH] feat(title): allow no-md title --- package-lock.json | 4 ++-- package.json | 2 +- src/generators/web/utils/processing.mjs | 7 +++++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7c42641e..7569e1d7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@node-core/doc-kit", - "version": "1.4.0", + "version": "1.4.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@node-core/doc-kit", - "version": "1.4.0", + "version": "1.4.1", "dependencies": { "@actions/core": "^3.0.0", "@heroicons/react": "^2.2.0", diff --git a/package.json b/package.json index d7001ba6..1564402e 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@node-core/doc-kit", "type": "module", - "version": "1.4.0", + "version": "1.4.1", "repository": { "type": "git", "url": "git+https://github.com/nodejs/doc-kit.git" diff --git a/src/generators/web/utils/processing.mjs b/src/generators/web/utils/processing.mjs index 2dd1355d..c4f23af7 100644 --- a/src/generators/web/utils/processing.mjs +++ b/src/generators/web/utils/processing.mjs @@ -193,11 +193,14 @@ export async function processBundles({ const results = await Promise.all( datas.map(async data => { const root = resolvePageRoot(data); + const title = data.title ?? data.heading.data.name; // Replace template placeholders with actual content const renderedHtml = populateWithEvaluation(template, { - title: data.heading.data.name - ? `${data.heading.data.name} | ${titleSuffix}` + title: title + ? titleSuffix + ? `${title} | ${titleSuffix}` + : title : titleSuffix, dehydrated: serverBundle.pages.get(`${data.api}.js`) ?? '', importMap: clientBundle.importMap?.replaceAll('/', root) ?? '',